Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forkJoin): catch and forward selector errors #3261

Merged
merged 2 commits into from
Jan 26, 2018

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Jan 26, 2018

Description:

Fixes forkJoin so that errors thrown from within the selector are no longer unhandled.

Related issue (if exists): #3216

@rxjs-bot
Copy link

Messages
📖

CJS: 1368.1KB, global: 733.0KB (gzipped: 118.1KB), min: 141.9KB (gzipped: 30.8KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.481% when pulling c96f4d2 on cartant:issue-3216 into 6a4ace4 on ReactiveX:master.

Copy link
Member

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benlesh benlesh merged commit e57bbb7 into ReactiveX:master Jan 26, 2018
@cartant cartant deleted the issue-3216 branch March 31, 2018 02:24
@lock
Copy link

lock bot commented Jun 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants